type stability and alloc reduction#8
Conversation
|
@maxfreu sorry, I seem to have missed your comment here. We're using this quite heavily in GeometryOps.jl now (see JuliaGeo/GeometryOps.jl#259) so would be happy to either co-maintain or move the repo to JuliaGeo, depending on your preference. |
Co-authored-by: Anshul Singhvi <[email protected]>
|
I tried this and somehow it wasn't faster |
|
Thanks guys! Pretty cool to receive a PR from you :) If you have no further tweaks, I'll merge. |
|
No more changes on my side! But you can expect more PRs, we will be using this everywhere :) |
|
love it, thanks! <3 btw: I don't remember why I used sortperm in the first place xD |
This PR:
sort!instead ofsortperminleafnodes/parentnodesas the vector is not used after the sort anywayscratchinsort!